Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(website): remove hardcoded accessions from e2e #1126

Merged

Conversation

TobiasKampmann
Copy link
Contributor

@TobiasKampmann TobiasKampmann commented Feb 26, 2024

resolves #1073

preview URL:

Summary

Screenshot

PR Checklist

  • All necessary documentation has been adapted.
  • The implemented feature is covered by an appropriate test.

@TobiasKampmann TobiasKampmann force-pushed the 1073-refactor-e2e-to-avoid-using-hardcoded-accessions branch from 1b58863 to 47bf928 Compare February 27, 2024 09:18
@TobiasKampmann TobiasKampmann force-pushed the 1073-refactor-e2e-to-avoid-using-hardcoded-accessions branch 3 times, most recently from 18a0a22 to f9fc590 Compare February 27, 2024 12:07
@TobiasKampmann TobiasKampmann changed the title feat(website): remove hardcoded accessions from e2e, wip feat(website): remove hardcoded accessions from e2e Feb 27, 2024
@TobiasKampmann TobiasKampmann marked this pull request as ready for review February 27, 2024 12:11
Copy link
Contributor

@fengelniederhammer fengelniederhammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (other than it might benefit from some minor refactorings)

website/tests/playwrightSetup.ts Outdated Show resolved Hide resolved
website/tests/e2e.fixture.ts Outdated Show resolved Hide resolved
website/tests/playwrightSetup.ts Show resolved Hide resolved
website/tests/playwrightSetup.ts Outdated Show resolved Hide resolved
feat(website): remove hardcoded accessions from e2e
@TobiasKampmann TobiasKampmann force-pushed the 1073-refactor-e2e-to-avoid-using-hardcoded-accessions branch from 6c94fa5 to 3efd25f Compare February 27, 2024 13:58
@TobiasKampmann TobiasKampmann merged commit c961dca into main Feb 27, 2024
12 checks passed
@TobiasKampmann TobiasKampmann deleted the 1073-refactor-e2e-to-avoid-using-hardcoded-accessions branch February 27, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor e2e to avoid using hardcoded accessions
2 participants